From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp44.i.mail.ru (smtp44.i.mail.ru [94.100.177.104]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 6C836446439 for ; Fri, 11 Sep 2020 13:37:18 +0300 (MSK) Date: Fri, 11 Sep 2020 13:37:17 +0300 From: Kirill Yukhin Message-ID: <20200911103717.ivj3ilw56luabm7a@tarantool.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Subject: Re: [Tarantool-patches] [PATCH v1] test: flaky replication/wal_off.test.lua test List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Alexander V. Tikhonov" Cc: tarantool-patches@dev.tarantool.org Hello, On 08 сен 14:50, Alexander V. Tikhonov wrote: > On heavy loaded hosts found the following issue: > > [035] --- replication/wal_off.result Fri Jul 3 04:29:56 2020 > [035] +++ replication/wal_off.reject Mon Sep 7 15:32:46 2020 > [035] @@ -47,6 +47,8 @@ > [035] ... > [035] while box.info.replication[wal_off_id].upstream.message ~= check do fiber.sleep(0) end > [035] --- > [035] +- error: '[string "while box.info.replication[wal_off_id].upstre..."]:1: attempt to > [035] + index field ''upstream'' (a nil value)' > [035] ... > [035] box.info.replication[wal_off_id].upstream ~= nil > [035] --- > > It happened because replication upstream status check occurred too > early, when its state was not set. To give the replication status > check routine ability to reach the needed 'stopped' state, it need > to wait for it using test_run:wait_upstream() routine. > > Closes #5278 > --- > > Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-5278-repl-wal-off > Issue: https://github.com/tarantool/tarantool/issues/5278 I've checked your patch into 1.10, 2.4, 2.5 and master. -- Regards, Kirill Yukhin