From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp55.i.mail.ru (smtp55.i.mail.ru [217.69.128.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 8F4E5469719 for ; Fri, 11 Sep 2020 13:35:50 +0300 (MSK) Date: Fri, 11 Sep 2020 13:35:49 +0300 From: Kirill Yukhin Message-ID: <20200911103549.bondkmw5wrflvesv@tarantool.org> References: <8128e93e56c1a4b9f1289fb0a5d6396bb47eb8e5.1599416974.git.avtikhon@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <8128e93e56c1a4b9f1289fb0a5d6396bb47eb8e5.1599416974.git.avtikhon@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH v1] test: flaky replication/gh-4606-admin-creds test List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Alexander V. Tikhonov" Cc: tarantool-patches@dev.tarantool.org Hello, On 06 сен 21:30, Alexander V. Tikhonov wrote: > On heavy loaded hosts found the following issue: > > [021] --- replication/gh-4606-admin-creds.result Wed Apr 15 15:47:41 2020 > [021] +++ replication/gh-4606-admin-creds.reject Sun Sep 6 20:23:09 2020 > [021] @@ -36,7 +36,42 @@ > [021] | ... > [021] i.replication[i.id % 2 + 1].upstream.status == 'follow' or i > [021] | --- > [021] - | - true > [021] + | - version: 2.6.0-52-g71a24b9f2 > [021] + | id: 2 > [021] + | ro: false > [021] + | uuid: 3921679b-d994-4cf0-a6ef-1f6a0d96fc79 > [021] + | package: Tarantool > [021] + | cluster: > [021] + | uuid: f27dfdfe-2802-486a-bc47-abc83b9097cf > [021] + | listen: unix/:/Users/tntmac02.tarantool.i/tnt/test/var/014_replication/replica_auth.socket-iproto > [021] + | replication_anon: > [021] + | count: 0 > [021] + | replication: > [021] + | 1: > [021] + | id: 1 > [021] + | uuid: a07cad18-d27f-48c4-8d56-96b17026702e > [021] + | lsn: 3 > [021] + | upstream: > [021] + | peer: admin@unix/:/Users/tntmac02.tarantool.i/tnt/test/var/014_replication/master.socket-iproto > [021] + | lag: 0.0030207633972168 > [021] + | status: disconnected > [021] + | idle: 0.44824500009418 > [021] + | message: timed out > [021] + | system_message: Operation timed out > [021] + | 2: > [021] + | id: 2 > [021] + | uuid: 3921679b-d994-4cf0-a6ef-1f6a0d96fc79 > [021] + | lsn: 0 > [021] + | signature: 3 > [021] + | status: running > [021] + | vclock: {1: 3} > [021] + | uptime: 1 > [021] + | lsn: 0 > [021] + | sql: [] > [021] + | gc: [] > [021] + | vinyl: [] > [021] + | memory: [] > [021] + | pid: 40326 > [021] | ... > [021] test_run:switch('default') > [021] | --- > > It happened because replication upstream status check occurred too > early, when it was only in 'disconnected' state. To give the > replication status check routine ability to reach the needed 'follow' > state, it need to wait for it using test_run:wait_upstream() routine. > > Closes #5233 > --- > > Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-5233-fix-4606 > Issue: https://github.com/tarantool/tarantool/issues/5233 I've checked your patch into 1.10, 2.4, 2.5 and master. -- Regards, Kirill Yukhin