From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kyukhin@tarantool.org>
Received: from smtp40.i.mail.ru (smtp40.i.mail.ru [94.100.177.100])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id CE030469719
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 11 Sep 2020 13:34:51 +0300 (MSK)
Date: Fri, 11 Sep 2020 13:34:50 +0300
From: Kirill Yukhin <kyukhin@tarantool.org>
Message-ID: <20200911103450.mur5yen45ejcciww@tarantool.org>
References: <faadba463b93c082aa511fcdb1d97d6721a6639b.1599406456.git.avtikhon@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <faadba463b93c082aa511fcdb1d97d6721a6639b.1599406456.git.avtikhon@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v1] test: flaky
	replication/gh-4402-info-errno.test.lua
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Hello,

On 06 сен 18:36, Alexander V. Tikhonov wrote:
> On heavy loaded hosts found the following issue:
> 
>   [004] --- replication/gh-4402-info-errno.result	Wed Jul 22 06:13:34 2020
>   [004] +++ replication/gh-4402-info-errno.reject	Wed Jul 22 06:41:14 2020
>   [004] @@ -32,7 +32,39 @@
>   [004]   | ...
>   [004]  d ~= nil and d.status == 'follow' or i
>   [004]   | ---
>   [004] - | - true
>   [004] + | - version: 2.6.0-10-g8df49e4
>   [004] + |   id: 1
>   [004] + |   ro: false
>   [004] + |   uuid: 41c4e3bf-cc3b-443d-88c9-39a9a8fe2df9
>   [004] + |   package: Tarantool
>   [004] + |   cluster:
>   [004] + |     uuid: 6ec7bcce-68e7-41a4-b84b-dc9236621579
>   [004] + |   listen: unix/:(socket)
>   [004] + |   replication_anon:
>   [004] + |     count: 0
>   [004] + |   replication:
>   [004] + |     1:
>   [004] + |       id: 1
>   [004] + |       uuid: 41c4e3bf-cc3b-443d-88c9-39a9a8fe2df9
>   [004] + |       lsn: 52
>   [004] + |     2:
>   [004] + |       id: 2
>   [004] + |       uuid: 8a989231-177a-4eb8-8030-c148bc752b0e
>   [004] + |       lsn: 0
>   [004] + |       downstream:
>   [004] + |         status: stopped
>   [004] + |         message: timed out
>   [004] + |         system_message: Connection timed out
>   [004] + |   signature: 52
>   [004] + |   status: running
>   [004] + |   vclock: {1: 52}
>   [004] + |   uptime: 27
>   [004] + |   lsn: 52
>   [004] + |   sql: []
>   [004] + |   gc: []
>   [004] + |   vinyl: []
>   [004] + |   memory: []
>   [004] + |   pid: 99
>   [004]   | ...
>   [004]
>   [004]  test_run:cmd('stop server replica')
> 
> It happened because replication downstream status check occurred too
> early, when it was only in 'stopped' state. To give the replication
> status check routine ability to reach the needed 'follow' state, it
> need to wait for it using test_run:wait_downstream() routine.
> 
> Closes #5235
> ---
> 
> Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-5235-fix-4402
> Issue: https://github.com/tarantool/tarantool/issues/5235

I've checked your patch into 2.4, 2.5 and master.

--
Regards, Kirill Yukhin