From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gorcunov@gmail.com>
Received: from mail-lj1-f194.google.com (mail-lj1-f194.google.com
 [209.85.208.194])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id BC2AA469719
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 10 Sep 2020 19:21:14 +0300 (MSK)
Received: by mail-lj1-f194.google.com with SMTP id a15so9007991ljk.2
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 10 Sep 2020 09:21:14 -0700 (PDT)
Date: Thu, 10 Sep 2020 19:21:09 +0300
From: Cyrill Gorcunov <gorcunov@gmail.com>
Message-ID: <20200910162109.GB269870@grain>
References: <20200909081955.45791-1-olegrok@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200909081955.45791-1-olegrok@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH] lua: fix panic in case when
 log.cfg.log incorrecly specified
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: olegrok@tarantool.org
Cc: tarantool-patches@dev.tarantool.org

On Wed, Sep 09, 2020 at 11:19:55AM +0300, olegrok@tarantool.org wrote:
> From: Oleg Babin <babinoleg@mail.ru>
> 
> This patch makes log.cfg{log = ...} behaviour the same as in
> box.cfg{log = ...} and fixes panic if "log" is incorrectly
> specified. For such purpose we export "say_parse_logger_type"
> function and use for logger type validation and logger type
> parsing.
> 
> Closes #5130
Reviewed-by: Cyrill Gorcunov <gorcunov@gmail.com>

Thanks!