From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp32.i.mail.ru (smtp32.i.mail.ru [94.100.177.92]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id DD42E469719 for ; Tue, 8 Sep 2020 17:51:22 +0300 (MSK) Date: Tue, 8 Sep 2020 17:51:21 +0300 From: Kirill Yukhin Message-ID: <20200908145121.o6fi6fdjqjltae4f@tarantool.org> References: <20200901103143.31898-1-i.kosarev@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200901103143.31898-1-i.kosarev@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH] msgpack: print mp_exp type as signed integer List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ilya Kosarev Cc: tarantool-patches@dev.tarantool.org, alexander.turenko@tarantool.org Hello, On 01 сен 13:31, Ilya Kosarev wrote: > MsgPack extension types allow applications to define > application-specific types. They consist of an 8-bit signed integer and > a byte array where the integer represents a kind of types and the byte > array represents data. Types from 0 to 127 are application-specific > types and types from -128 to -1 are reserved for predefined types. > However, extension types were printed as unsigned integers. Now it is > fixed and extension types are being printed in a correct way as signed > integers. Also the typo in word "Unsupported" was fixed. According test > case is introduced. > > Closes #5016 > --- > Branch: https://github.com/tarantool/tarantool/tree/i.kosarev/gh-5016-fix-extension-decoding > Issue: https://github.com/tarantool/tarantool/issues/5016 I've checked your patch into 2.4, 2.5 and master. -- Regards, Kirill Yukhin