From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp49.i.mail.ru (smtp49.i.mail.ru [94.100.177.109]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 6EDD7469719 for ; Tue, 8 Sep 2020 17:49:04 +0300 (MSK) Date: Tue, 8 Sep 2020 17:49:03 +0300 From: Kirill Yukhin Message-ID: <20200908144903.q7hgs4jfstthrpx6@tarantool.org> References: <20200901162751.23037-1-i.kosarev@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200901162751.23037-1-i.kosarev@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH] rtree: add comments on ignored rtree_search() return value List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ilya Kosarev Cc: tarantool-patches@dev.tarantool.org Hello, On 01 сен 19:27, Ilya Kosarev wrote: > rtree_search() has return value and it is ignored in some cases. > Although it is totally fine it seems to be reasonable to comment those > cases as far as such usage might be questionable. > > Closes #2052 > --- > Branch: https://github.com/tarantool/tarantool/tree/i.kosarev/gh-2052-rtree_search()-result-ignored In future, please avoid using of braces in branch names. > Issue: https://github.com/tarantool/tarantool/issues/2052 LGTM. I've checked your patch into 1.10, 2.4, 2.5 and master. -- Regards, Kirill Yukhin