From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <alexander.turenko@tarantool.org>
Received: from smtp47.i.mail.ru (smtp47.i.mail.ru [94.100.177.107])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id B542F43040F
 for <tarantool-patches@dev.tarantool.org>;
 Tue,  1 Sep 2020 16:57:25 +0300 (MSK)
Date: Tue, 1 Sep 2020 16:57:23 +0300
From: Alexander Turenko <alexander.turenko@tarantool.org>
Message-ID: <20200901135723.ao2d5xc4hl5rcert@tkn_work_nb>
References: <cover.1595943364.git.sergeyb@tarantool.org>
 <1f495519687c8e037c638ccabab28e23882a41df.1595943364.git.sergeyb@tarantool.org>
 <20200728164128.7sbgbjw3qiayuouc@tkn_work_nb>
 <20200831111424.GC94343@pony.bronevichok.ru>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20200831111424.GC94343@pony.bronevichok.ru>
Subject: Re: [Tarantool-patches] [PATCH 1/2] src: return back import of
	table.clear() method
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Sergey Bronnikov <sergeyb@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org

LGTM except one nit (no need to re-review with me):

Please, remove the changelog entry from the commit message. It is for
release notes and should be placed in a cover letter (or under --- for a
singleton patchset). There are cons and pros, but current process is so.

WBR, Alexander Turenko.