From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id E91F6431780 for ; Thu, 27 Aug 2020 21:52:47 +0300 (MSK) Date: Thu, 27 Aug 2020 21:42:19 +0300 From: Igor Munkin Message-ID: <20200827184219.GC18920@tarantool.org> References: <35a19def79a9cbc46dabdfa579869af9e4e589fb.1595794764.git.skaplun@tarantool.org> <20200826144837.GA18920@tarantool.org> <20200826155207.GA49@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200826155207.GA49@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH v2 1/2] core: introduce various platform metrics List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Sergey Ostanevich Cc: tarantool-patches@dev.tarantool.org Sergos, On 26.08.20, Sergey Ostanevich wrote: > On 26 авг 17:48, Igor Munkin wrote: > > > > Furthermore, please address the comments I left regarding the patch > > you've made for CNEW IR[1] and squash it with this one. > > > > Sergos, do we need other JIT architectures to be patched in scope of > > this series or Sergey can just add the corresponding preprocessor > > condition to stub the issue for now? > > AFAU the CNEW IR appeared in src/lj_asm_x86.h so I didn't get what > preprocessor condition do you mean. Well, I clarify my point a bit: Sergey can implement cdata counter only for x86 platform both in compiler and interpreter. Other platforms will report nothing (i.e. zeros) for this metric and the issue can be fixed on demand. > Also, the inconsistency with the allocated CDATA counter will appear > anyways, so it needs to be implemented for other targets also. Looks > like a not-so-big deal? Yes, but I believe testing will take much more time than implementation. > BTW, AlexanderTi made a successful build and a little less successful > run on an ARM emulator that took some reasonable time. So there's a > way to test the change for ARM. Both PPC and MIPS I suppose would be > just fine to test for successful build. OK then, so I guess Sergey can make the patch for other arches as well. > > > > > > > [1]: https://lists.tarantool.org/pipermail/tarantool-patches/2020-August/019012.html > > > > -- > > Best regards, > > IM -- Best regards, IM