From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <korablev@tarantool.org>
Received: from smtp43.i.mail.ru (smtp43.i.mail.ru [94.100.177.103])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 9F89C430407
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 21 Aug 2020 11:46:26 +0300 (MSK)
Date: Fri, 21 Aug 2020 08:46:25 +0000
From: Nikita Pettik <korablev@tarantool.org>
Message-ID: <20200821084625.GA6452@tarantool.org>
References: <20200814145143.23720-1-i.kosarev@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20200814145143.23720-1-i.kosarev@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v3] tuple: drop extra restrictions
	for multikey index
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Ilya Kosarev <i.kosarev@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

On 14 Aug 17:51, Ilya Kosarev wrote:
> Multikey index did not work properly with nullable root field in
> tuple_raw_multikey_count(). Now it is fixed and corresponding
> restrictions are dropped. This also means that we can drop implicit
> nullability update for array/map fields and make all fields nullable
> by default, as it was until e1d3fe8ab8eed65394ad17409401a93b6fcdc435
> (tuple format: don't allow null where array/map is expected), as far as
> default non-nullability itself doesn't solve any real problems while
> providing confusing behavior (gh-5027).
> 
> Follow-up #5027
> Closes #5192
> 
> @TarantoolBot document
> Title: tuple: allow nullable multikey index root
> Update the documentation for space_object:create_index() to reflect
> that it is now safe for multikey index root to be nullable.
> Previously it was not safe to insert, for example, box.NULL as an array
> field which elements are the part of multikey index due to error in
> counter of multikey index keys in tuple. It was partly fixed using
> default non-nullability for tuple fields. In 2.3.3 the restriction on
> nullable multikey index root was introduced. Now the counter problem is
> fixed and all tuple fields are nullable by default as before 2.2.1.
> ---
> Branch: https://github.com/tarantool/tarantool/tree/i.kosarev/gh-5192-fix-multikey-index-restrictions
> Issue: https://github.com/tarantool/tarantool/issues/5192
> 
> @ChangeLog:
>  * Dropped restrictions on nullable multikey index root. They were
>  introduced due to inaccuracy in multikey index realization. It is
>  now fixed. Also all fields are now nullable by default as it was
>  before 2.2.1 (gh-5192).
> 
>  Changes in v2:
> - removed insignificant changes
> - fixed tests comments
> 
>  Changes in v3:
> - fixed some nits
> - added docbot request

LGTM now.