From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gorcunov@gmail.com>
Received: from mail-lj1-f195.google.com (mail-lj1-f195.google.com
 [209.85.208.195])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id D67A0430409
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 20 Aug 2020 10:13:24 +0300 (MSK)
Received: by mail-lj1-f195.google.com with SMTP id g6so934573ljn.11
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 20 Aug 2020 00:13:24 -0700 (PDT)
Date: Thu, 20 Aug 2020 10:13:21 +0300
From: Cyrill Gorcunov <gorcunov@gmail.com>
Message-ID: <20200820071321.GQ2074@grain>
References: <20200819213442.1099018-1-gorcunov@gmail.com>
 <20200819213442.1099018-5-gorcunov@gmail.com>
 <4c0358f3-130f-66d1-770d-c6659b6bbdbd@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4c0358f3-130f-66d1-770d-c6659b6bbdbd@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v9 4/7] qsync: direct write of
 CONFIRM/ROLLBACK into a journal
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tml <tarantool-patches@dev.tarantool.org>

On Thu, Aug 20, 2020 at 12:43:45AM +0200, Vladislav Shpilevoy wrote:
> > +	if (journal_write(entry) != 0 || entry->res < 0) {
> > +		diag_set(ClientError, ER_WAL_IO);
> > +		diag_log();
> > +		/*
> > +		 * XXX: the stub is supposed to be removed once it is defined
> > +		 * what to do when a synchro request WAL write fails. One of
> > +		 * the possible solutions: log the error, keep the limbo
> > +		 * queue as is and probably put in rollback mode. Then
> > +		 * provide a hook to call manually when WAL problems are fixed.
> > +		 * Or retry automatically with some period.
> > +		 */
> > +		panic("Could not write a synchro request to WAL: "
> > +		      "lsn = %lld, type = %s\n", lsn,
> > +		      type == IPROTO_CONFIRM ? "CONFIRM" : "ROLLBACK");
> 
> Why did you inline iproto_type_name(type)?

It happened to sneak in from old commits (I've cherry picked it,
and there were no such code previously). I've fixed it and pushed
into the branch. Thanks for noticing!