From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-f193.google.com (mail-lj1-f193.google.com [209.85.208.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 32F44430407 for ; Wed, 19 Aug 2020 23:49:31 +0300 (MSK) Received: by mail-lj1-f193.google.com with SMTP id m22so26872851ljj.5 for ; Wed, 19 Aug 2020 13:49:31 -0700 (PDT) Date: Wed, 19 Aug 2020 23:49:27 +0300 From: Cyrill Gorcunov Message-ID: <20200819204927.GP2074@grain> References: <20200817133918.875558-1-gorcunov@gmail.com> <20200817133918.875558-7-gorcunov@gmail.com> <4f76adf1-3185-d4e2-3a88-8d312c9e5951@tarantool.org> <20200817221403.GL2074@grain> <052d70b3-a11c-05db-15e7-87bd1b86ba19@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <052d70b3-a11c-05db-15e7-87bd1b86ba19@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH v8 6/9] applier: add shorthands to queue access List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladislav Shpilevoy Cc: tml On Wed, Aug 19, 2020 at 10:37:30PM +0200, Vladislav Shpilevoy wrote: > Hi! Today you said you did all the review fixes. I see that > the branch didn't change, and this comment is still not > addressed. > >> > >> The code is ugly as hell without it :/ > > > > There are many ugly things, but it does not mean we need to rush > > changing them. It was discussed already many times. Please, drop > > this commit. It is not necessary. It does not interfere with the > > other patches in a single line. Hmm, seems this your reply somehow drown in my inbox :( I'm pretty damn sure that when we're changin the code we should improve it if we can. I'll update the branch and remove this commit.