From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gorcunov@gmail.com>
Received: from mail-lj1-f193.google.com (mail-lj1-f193.google.com
 [209.85.208.193])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 15589430407
 for <tarantool-patches@dev.tarantool.org>;
 Tue, 18 Aug 2020 01:16:24 +0300 (MSK)
Received: by mail-lj1-f193.google.com with SMTP id i10so19223420ljn.2
 for <tarantool-patches@dev.tarantool.org>;
 Mon, 17 Aug 2020 15:16:24 -0700 (PDT)
Date: Tue, 18 Aug 2020 01:16:21 +0300
From: Cyrill Gorcunov <gorcunov@gmail.com>
Message-ID: <20200817221621.GM2074@grain>
References: <20200817133918.875558-1-gorcunov@gmail.com>
 <20200817133918.875558-6-gorcunov@gmail.com>
 <fdfefba0-72a1-b4f6-1f71-19ff7346febc@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <fdfefba0-72a1-b4f6-1f71-19ff7346febc@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v8 5/9] qsync: direct write of
 CONFIRM/ROLLBACK into a journal
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tml <tarantool-patches@dev.tarantool.org>

On Mon, Aug 17, 2020 at 10:49:19PM +0200, Vladislav Shpilevoy wrote:
> > +	if (journal_write(entry) != 0 || entry->res < 0) {
> > +		diag_set(ClientError, ER_WAL_IO);
> > +		diag_log();
> > +		/*
> > +		 * XXX: the stub is supposed to be removed once it is defined what to do
> > +		 * when a synchro request WAL write fails. One of the possible
> > +		 * solutions: log the error, keep the limbo queue as is and probably put
> > +		 * in rollback mode. Then provide a hook to call manually when WAL
> > +		 * problems are fixed. Or retry automatically with some period.
> 
> Still out of 80 symbols.

Shame on me :( You already pointed and I remember this problem, but then
been rebasing and it flew out of my head. I could force push update if
this is the only problem.