From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-f195.google.com (mail-lj1-f195.google.com [209.85.208.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 90A6F430407 for ; Tue, 18 Aug 2020 01:14:06 +0300 (MSK) Received: by mail-lj1-f195.google.com with SMTP id t23so19223967ljc.3 for ; Mon, 17 Aug 2020 15:14:06 -0700 (PDT) Date: Tue, 18 Aug 2020 01:14:03 +0300 From: Cyrill Gorcunov Message-ID: <20200817221403.GL2074@grain> References: <20200817133918.875558-1-gorcunov@gmail.com> <20200817133918.875558-7-gorcunov@gmail.com> <4f76adf1-3185-d4e2-3a88-8d312c9e5951@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4f76adf1-3185-d4e2-3a88-8d312c9e5951@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH v8 6/9] applier: add shorthands to queue access List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladislav Shpilevoy Cc: tml On Mon, Aug 17, 2020 at 10:49:23PM +0200, Vladislav Shpilevoy wrote: > It seems this commit is not needed - I dropped it and nothing changed. > Even no merge/rebase conflicts. > > On 17.08.2020 15:39, Cyrill Gorcunov wrote: > > We need to access first and last xrow in a queue > > frenquently and opencoded variants are too ugly. > > frenquently -> frequently. The code is ugly as hell without it :/ We use them not once in the code that's why I made helpers. But I won't insist, drop it if you prefer.