From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gorcunov@gmail.com>
Received: from mail-lj1-f194.google.com (mail-lj1-f194.google.com
 [209.85.208.194])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id D1F3B430407
 for <tarantool-patches@dev.tarantool.org>;
 Mon, 17 Aug 2020 15:42:38 +0300 (MSK)
Received: by mail-lj1-f194.google.com with SMTP id m22so17275929ljj.5
 for <tarantool-patches@dev.tarantool.org>;
 Mon, 17 Aug 2020 05:42:38 -0700 (PDT)
Date: Mon, 17 Aug 2020 15:42:35 +0300
From: Cyrill Gorcunov <gorcunov@gmail.com>
Message-ID: <20200817124235.GJ2074@grain>
References: <20200814211442.667099-1-gorcunov@gmail.com>
 <20200814211442.667099-8-gorcunov@gmail.com>
 <af0743ac-3493-0c29-3380-21d41c6a8f1b@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <af0743ac-3493-0c29-3380-21d41c6a8f1b@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v7 7/8] applier: process synchro
 requests without txn engine
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tml <tarantool-patches@dev.tarantool.org>

On Sat, Aug 15, 2020 at 05:06:05PM +0200, Vladislav Shpilevoy wrote:
> > +static struct synchro_entry *
> > +synchro_entry_new(struct applier *applier,
> > +		  struct xrow_header *applier_row,
> > +		  struct synchro_request *req)
> > +{
> > +	struct synchro_entry *entry;
> > +	size_t size = sizeof(*entry) + sizeof(struct xrow_header *);
> 
> 6. Why don't you just add 'struct xrow_header*[1]' to the end of
> struct synchro_entry? There is no a case, when the entry is needed
> without the xrow_header pointer in the end.

This is forbidden by asan and some other compilers we've in travis runs.
I've been already trying.

Thanks for all comments, Vlad. I've merged your changes. Once tests
are passed I'll send new series out.