From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gorcunov@gmail.com>
Received: from mail-lj1-f195.google.com (mail-lj1-f195.google.com
 [209.85.208.195])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 06058430407
 for <tarantool-patches@dev.tarantool.org>;
 Sat, 15 Aug 2020 19:26:10 +0300 (MSK)
Received: by mail-lj1-f195.google.com with SMTP id g6so12985328ljn.11
 for <tarantool-patches@dev.tarantool.org>;
 Sat, 15 Aug 2020 09:26:10 -0700 (PDT)
Date: Sat, 15 Aug 2020 19:26:07 +0300
From: Cyrill Gorcunov <gorcunov@gmail.com>
Message-ID: <20200815162607.GF2074@grain>
References: <20200814211442.667099-1-gorcunov@gmail.com>
 <20200814211442.667099-5-gorcunov@gmail.com>
 <19c845c0-6cf9-288b-1cb6-942681d93ec3@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <19c845c0-6cf9-288b-1cb6-942681d93ec3@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v7 4/8] qsync: direct write of
 CONFIRM/ROLLBACK into a journal
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tml <tarantool-patches@dev.tarantool.org>

On Sat, Aug 15, 2020 at 05:04:27PM +0200, Vladislav Shpilevoy wrote:
> > +	char buf[sizeof(struct journal_entry) +
> > +		 sizeof(struct xrow_header *)];
> 
> 2. Is there a guarantee, that 'buf' will be aligned by at least
> 8 bytes?

Yup. On 32bit machines it would be 4 bytes aligned, on 64bit -- 8 byte
(this is basically how stack management works by default).

I'll address the rest of comments. Thanks!