From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kyukhin@tarantool.org>
Received: from smtp3.mail.ru (smtp3.mail.ru [94.100.179.58])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 14720430407
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 13 Aug 2020 14:49:00 +0300 (MSK)
Date: Thu, 13 Aug 2020 14:48:59 +0300
From: Kirill Yukhin <kyukhin@tarantool.org>
Message-ID: <20200813114859.axmmoc7z2c227v6j@tarantool.org>
References: <20200806131955.3400088-1-yaroslav.dynnikov@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20200806131955.3400088-1-yaroslav.dynnikov@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH] Ensure all curl symbols are exported
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Yaroslav Dynnikov <yaroslav.dynnikov@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org, Vladislav Shpilevoy <v.shpilevoy@tarantool.org>, Alexander Turenko <alexander.turenko@tarantool.org>

Hello,

On 06 авг 16:19, Yaroslav Dynnikov wrote:
> In the recent update of libcurl (2.5.0-278-g807c7fa58) its layout has
> changed: private function `Curl_version_init()` which used to fill-in
> info structure was eliminated. As a result, no symbols for
> `libcurl_la-version.o` remained used, so it wasn't included in tarantool
> binary. And `curl_version` and `curl_version_info` symbols went missing.
> 
> According to libcurl naming conventions all exported symbols are named
> as `curl_*`. This patch lists them all explicitly in `exprots.h` and
> adds the test.
> 
> Close #5223
> 
> Issue: https://github.com/tarantool/tarantool/issues/5223
> Branch: https://github.com/tarantool/tarantool/tree/rosik/gh-5223-missing-curl-symbols

I've checked your patch into master.
In future, could you please append a Relase Notes entry to your patches.

--
Regards, Kirill Yukhin