From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <korablev@tarantool.org>
Received: from smtp56.i.mail.ru (smtp56.i.mail.ru [217.69.128.36])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id E45A2430407
 for <tarantool-patches@dev.tarantool.org>;
 Sat,  8 Aug 2020 17:23:01 +0300 (MSK)
Date: Sat, 8 Aug 2020 14:23:01 +0000
From: Nikita Pettik <korablev@tarantool.org>
Message-ID: <20200808142301.GA28157@tarantool.org>
References: <cover.1595985135.git.korablev@tarantool.org>
 <2566473a-c279-5b2a-0864-aee5c0e930db@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <2566473a-c279-5b2a-0864-aee5c0e930db@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH 0/2] vinyl: rework upsert internals
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

On 31 Jul 01:32, Vladislav Shpilevoy wrote:
> Hi! Thanks for the patchset!
> 
> On 29.07.2020 03:15, Nikita Pettik wrote:
> > Issues:
> > https://github.com/tarantool/tarantool/issues/1622
> > https://github.com/tarantool/tarantool/issues/5105
> > https://github.com/tarantool/tarantool/issues/5092
> > https://github.com/tarantool/tarantool/issues/5107
> > Branch:
> > https://github.com/tarantool/tarantool/tree/np/gh-5107-dont-squash-ops
> 
> Need a changelog here.

Added in V2:

@ChangeLog:
 - Rework upsert operation in vinyl so that now (gh-5107):
   - if upsert can't be applied it is skipped and corresponding error is logged (gh-1622);
   - upserts now follow associative property: result of several upserts
     doesn't depend on the order of their application (gh-5105);
   - upserts referring to -1 fieldno are handled correctly now (gh-5087).