From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gorcunov@gmail.com>
Received: from mail-lf1-f66.google.com (mail-lf1-f66.google.com
 [209.85.167.66])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 03E8E445320
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 31 Jul 2020 16:59:16 +0300 (MSK)
Received: by mail-lf1-f66.google.com with SMTP id u13so3453327lff.11
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 31 Jul 2020 06:59:16 -0700 (PDT)
Date: Fri, 31 Jul 2020 16:59:13 +0300
From: Cyrill Gorcunov <gorcunov@gmail.com>
Message-ID: <20200731135913.GI3264@grain>
References: <cover.1596148501.git.v.shpilevoy@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <cover.1596148501.git.v.shpilevoy@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH 0/3] Qsync tricky crashes
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

On Fri, Jul 31, 2020 at 12:37:42AM +0200, Vladislav Shpilevoy wrote:
> The patchset fixes 2 crashes in qsync. 5185 wasn't reproduced, but a similar
> test gave another crash, fixed here.
> 
> Branch: http://github.com/tarantool/tarantool/tree/gerold103/gh-5185-5195-qsync-crashes
> Issue: https://github.com/tarantool/tarantool/issues/5185
> Issue: https://github.com/tarantool/tarantool/issues/5195
> 
> @ChangeLog
> * Fixed a crash when replica cleared synchronous transaction queue, while it was not empty on master (gh-5195).
> * Fixed a crash when synchronous transaction rollback and confirm could be written simultaneously for the same LSN (gh-5185).

Ack. Lets give them a spin.