From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-f194.google.com (mail-lj1-f194.google.com [209.85.208.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 386D1445320 for ; Thu, 30 Jul 2020 11:49:42 +0300 (MSK) Received: by mail-lj1-f194.google.com with SMTP id 185so17800062ljj.7 for ; Thu, 30 Jul 2020 01:49:42 -0700 (PDT) Date: Thu, 30 Jul 2020 11:49:39 +0300 From: Cyrill Gorcunov Message-ID: <20200730084939.GF3264@grain> References: <04de5b4a0f7859909155cb9f52e9fd45a338a0e8.1596065870.git.v.shpilevoy@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <04de5b4a0f7859909155cb9f52e9fd45a338a0e8.1596065870.git.v.shpilevoy@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH 1/1] txn_limbo: panic when synchro WAL write fails List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladislav Shpilevoy Cc: tarantool-patches@dev.tarantool.org On Thu, Jul 30, 2020 at 01:39:05AM +0200, Vladislav Shpilevoy wrote: > CONFIRM and ROLLBACK go to WAL. Their WAL write can fail just like > any other WAL write. However it is not clear what to do in that > case, especially in case of ROLLBACK fail. > > The patch adds panic() stub so as to at least terminate the > instance. Before the patch it would work like nothing happened, > with undefined behaviour. > > Closes #5159 This bunch of panicings is priceless :-) We _are_ to make some more sane handling in near future. For a while this is fine. Reviewed-by: Cyrill Gorcunov