From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gorcunov@gmail.com>
Received: from mail-lj1-f196.google.com (mail-lj1-f196.google.com
 [209.85.208.196])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 31D70445320
 for <tarantool-patches@dev.tarantool.org>;
 Wed, 29 Jul 2020 20:04:58 +0300 (MSK)
Received: by mail-lj1-f196.google.com with SMTP id t23so2328476ljc.3
 for <tarantool-patches@dev.tarantool.org>;
 Wed, 29 Jul 2020 10:04:58 -0700 (PDT)
Date: Wed, 29 Jul 2020 20:04:54 +0300
From: Cyrill Gorcunov <gorcunov@gmail.com>
Message-ID: <20200729170454.GA3264@grain>
References: <cover.1596040943.git.i.kosarev@tarantool.org>
 <482137955bbc7004f23e5c3ffb7d65b3ab0e223f.1596040943.git.i.kosarev@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <482137955bbc7004f23e5c3ffb7d65b3ab0e223f.1596040943.git.i.kosarev@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH 1/2] fiber: set diagnostics at
	madvise/mprotect failure
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Ilya Kosarev <i.kosarev@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

On Wed, Jul 29, 2020 at 07:50:41PM +0300, Ilya Kosarev wrote:
>  
>  /**
>   * Injection state
>   */
>  struct errinj {
> -	/** Name, e.g "ERRINJ_WAL_WRITE" */
> -	const char *name;
> -	/** Type, e.g. BOOL, U64, DOUBLE */
> -	enum errinj_type type;
> -	union {
> -		/** bool parameter */
> -		bool bparam;
> -		/** integer parameter */
> -		int64_t iparam;
> +    /** Name, e.g "ERRINJ_WAL_WRITE" */
> +    const char *name;
> +    /** Type, e.g. BOOL, U64, DOUBLE */
> +    enum errinj_type type;

Ilya, the whole patch is tabs/space screwed. Is is supposed to be so?