From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <alexander.turenko@tarantool.org>
Received: from smtp53.i.mail.ru (smtp53.i.mail.ru [94.100.177.113])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 7B1B0445322
 for <tarantool-patches@dev.tarantool.org>;
 Tue, 28 Jul 2020 19:42:25 +0300 (MSK)
Date: Tue, 28 Jul 2020 19:41:30 +0300
From: Alexander Turenko <alexander.turenko@tarantool.org>
Message-ID: <20200728164130.j7dvrpz7azdonqqa@tkn_work_nb>
References: <cover.1595943364.git.sergeyb@tarantool.org>
 <a448b2909838bbc065dacf45791634920bfa09a1.1595943364.git.sergeyb@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <a448b2909838bbc065dacf45791634920bfa09a1.1595943364.git.sergeyb@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH 2/2] test: add regression test for
	table.clear()
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: sergeyb@tarantool.org
Cc: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org

> --- /dev/null
> +++ b/test/box-tap/gh-5210-table-clear.test.lua

I would place it into app-tap, because it is not related to box.

> +t = {a = 1, b = 2}

I would use 'local' here.

> +test:is(table.clear(t), nil, 'table clear')

I would check that the table is cleared: say, using `next(t)`. It must
return `nil` for an empty table.

WBR, Alexander Turenko.