From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kyukhin@tarantool.org>
Received: from smtp51.i.mail.ru (smtp51.i.mail.ru [94.100.177.111])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id A0F2D445320
 for <tarantool-patches@dev.tarantool.org>;
 Tue, 28 Jul 2020 18:42:13 +0300 (MSK)
Date: Tue, 28 Jul 2020 18:42:12 +0300
From: Kirill Yukhin <kyukhin@tarantool.org>
Message-ID: <20200728154212.wbghrqdvru5xchei@tarantool.org>
References: <5358833fffe09a551632732d6e63af36768647e3.1595947426.git.avtikhon@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <5358833fffe09a551632732d6e63af36768647e3.1595947426.git.avtikhon@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v1] gitlab-ci: restore lto testing
	on OSX
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org, Alexander Turenko <alexander.turenko@tarantool.org>

Hello,

On 28 июл 18:09, Alexander V. Tikhonov wrote:
> Found that after commit:
> 
>   7faa1abe2b2dedd3a5d2971ddd7c5b9ce55c30b2 "gitlab-ci: implement OSX 10.14 testing on mac mini"
> 
> the variable environment CMAKE_EXTRA_PARAMS, which turns on LTO flag
> on OSX compilation was mistakenly missed to be updated and LTO feature
> was disabled on OSX testing in real.
> 
> After it later commit:
> 
>   a94a9b3fd629b5abbc99a23ba527cd91e5c6ebf5 "lua/log: add ability to configure logging early"
> 
> added the missed LTO error, which was fixed at:
> 
>   625095d95c5d1962c02c124fcba098e527f017fd "lua/log: add missing exports"
> 
> Closes #5160

LGTM.
I've checked your patch into 1.10 2.4 2.5 and master.

--
Regards, Kirill Yukhin