From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kyukhin@tarantool.org>
Received: from smtp3.mail.ru (smtp3.mail.ru [94.100.179.58])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id AA9A1445320
 for <tarantool-patches@dev.tarantool.org>;
 Tue, 28 Jul 2020 17:08:02 +0300 (MSK)
Date: Tue, 28 Jul 2020 17:08:02 +0300
From: Kirill Yukhin <kyukhin@tarantool.org>
Message-ID: <20200728140801.qeb2nwexxbpl6ves@tarantool.org>
References: <20200728132742.504810-1-gorcunov@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20200728132742.504810-1-gorcunov@gmail.com>
Subject: Re: [Tarantool-patches] [PATCH] lua/log: add missing exports
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: tml <tarantool-patches@dev.tarantool.org>

Hello,

On 28 июл 16:27, Cyrill Gorcunov wrote:
> When building with LTO non exported symbols might
> be discarded while we have implicit use in log.lua
> code.
> 
> Introduced by a94a9b3fd629b5abbc99a23ba527cd91e5c6ebf5
> 
> Fixes #5160

LGTM.
I've checked your patch into 2.5 and master.

--
Regards, Kirill Yukhin