From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <avtikhon@tarantool.org>
Received: from smtp48.i.mail.ru (smtp48.i.mail.ru [94.100.177.108])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 05BF3445320
 for <tarantool-patches@dev.tarantool.org>;
 Tue, 28 Jul 2020 16:48:39 +0300 (MSK)
Date: Tue, 28 Jul 2020 16:48:37 +0300
From: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
Message-ID: <20200728134837.GA8171@hpalx>
References: <20200728132742.504810-1-gorcunov@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200728132742.504810-1-gorcunov@gmail.com>
Subject: Re: [Tarantool-patches] [PATCH] lua/log: add missing exports
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: tarantool-patches@dev.tarantool.org

Hi Cyrill, I've checked your patch and it fixed LTO build on OSX.
Please proceed with it, patch LGTM.

On Tue, Jul 28, 2020 at 04:27:42PM +0300, Cyrill Gorcunov wrote:
> When building with LTO non exported symbols might
> be discarded while we have implicit use in log.lua
> code.
> 
> Introduced by a94a9b3fd629b5abbc99a23ba527cd91e5c6ebf5
> 
> Fixes #5160
> 
> Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
> ---
>  src/exports.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/src/exports.h b/src/exports.h
> index fe3b31dba..7cf283e5b 100644
> --- a/src/exports.h
> +++ b/src/exports.h
> @@ -350,6 +350,8 @@ EXPORT(PMurHash32_Result)
>  EXPORT(port_destroy)
>  EXPORT(random_bytes)
>  EXPORT(_say)
> +EXPORT(say_logger_init)
> +EXPORT(say_logger_initialized)
>  EXPORT(say_logrotate)
>  EXPORT(say_set_log_format)
>  EXPORT(say_set_log_level)
> -- 
> 2.26.2
>