From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-f195.google.com (mail-lj1-f195.google.com [209.85.208.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id B2EDD445320 for ; Fri, 24 Jul 2020 21:17:00 +0300 (MSK) Received: by mail-lj1-f195.google.com with SMTP id d17so10904785ljl.3 for ; Fri, 24 Jul 2020 11:17:00 -0700 (PDT) Date: Fri, 24 Jul 2020 21:16:57 +0300 From: Cyrill Gorcunov Message-ID: <20200724181657.GH60766@grain> References: <20200723122942.196011-1-gorcunov@gmail.com> <4088335b-304d-e628-9304-b4794a869aba@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4088335b-304d-e628-9304-b4794a869aba@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH v2 0/5] qsync: write CONFIRM/ROLLBACK without txn engine List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladislav Shpilevoy Cc: tml On Fri, Jul 24, 2020 at 12:13:58AM +0200, Vladislav Shpilevoy wrote: > It is worth fixing txn.c in the same patchset. > > txn_add_redo(), shouldn't work with synchro requests anymore. > > Probably some other things can be simplified too. You need to > look at txn.c history to see what else was added here related to > writing synchro requests, and remove it. I'll take a look, thanks!