From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gorcunov@gmail.com>
Received: from mail-lf1-f65.google.com (mail-lf1-f65.google.com
 [209.85.167.65])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 149E8445320
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 24 Jul 2020 21:08:51 +0300 (MSK)
Received: by mail-lf1-f65.google.com with SMTP id 140so5667237lfi.5
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 24 Jul 2020 11:08:51 -0700 (PDT)
Date: Fri, 24 Jul 2020 21:08:47 +0300
From: Cyrill Gorcunov <gorcunov@gmail.com>
Message-ID: <20200724180847.GF60766@grain>
References: <20200723122942.196011-1-gorcunov@gmail.com>
 <20200723122942.196011-6-gorcunov@gmail.com>
 <fe215dc2-19ac-1995-7d23-2c119313b364@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <fe215dc2-19ac-1995-7d23-2c119313b364@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v2 5/7] qsync: provide a way to
 encode preallocated CONFIRM/ROLLBACK entries
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tml <tarantool-patches@dev.tarantool.org>

On Fri, Jul 24, 2020 at 12:10:57AM +0200, Vladislav Shpilevoy wrote:
> > +
> > +/**
> > + * Encode the CONFIRM or ROLLBACK to row body and set row type.
> > + * @param row xrow header.
> > + * @param body body to encode.
> > + * @param replica_id master's instance id.
> > + * @param lsn last confirmed lsn.
> > + * @param type IPROTO_CONFIRM or IPROTO_ROLLBACK.
> 
> 1. Lets start sentences from capital letters.

Another code in this file doesn't use such convention but fine, will do.

> 2. I would also rename xrow_encode_confirm_rollback -> xrow_encode_synchro.
> While we are here. I don't really like the current name. Too long, and
> a bit confusing. When I saw it first time, I thought it encodes confirmation
> of a rollback.

Done.