From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-f194.google.com (mail-lj1-f194.google.com [209.85.208.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 03FC7445320 for ; Thu, 23 Jul 2020 14:41:22 +0300 (MSK) Received: by mail-lj1-f194.google.com with SMTP id q7so5993127ljm.1 for ; Thu, 23 Jul 2020 04:41:22 -0700 (PDT) Date: Thu, 23 Jul 2020 14:41:19 +0300 From: Cyrill Gorcunov Message-ID: <20200723114119.GB60766@grain> References: <20200722153359.134718-1-gorcunov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200722153359.134718-1-gorcunov@gmail.com> Subject: Re: [Tarantool-patches] [PATCH 0/5] qsync: write confirm/rollback without txn engine List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: tml Cc: Vladislav Shpilevoy On Wed, Jul 22, 2020 at 06:33:54PM +0300, Cyrill Gorcunov wrote: > Vlad, take a look please once time permit. Note the series is on top > of your series "[PATCH 0/2] Make txn_commit() simpler" > > I think in our wal engine we should go further and eliminate completion > calls for synchronous writes completely (internally WAL could setup > completion to fiber_wakeup and reuse async engine) but from API it would > not call completion associated with transactions ever. But such redesign > is defenitely for other series. > > Anyway in this series we make a first approach to not use txn engine when > we have to simply write confirm/rollback record into a journal. Drop this series, please. v2 will be published.