From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gorcunov@gmail.com>
Received: from mail-lj1-f195.google.com (mail-lj1-f195.google.com
 [209.85.208.195])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 26227445320
 for <tarantool-patches@dev.tarantool.org>;
 Wed, 22 Jul 2020 18:41:57 +0300 (MSK)
Received: by mail-lj1-f195.google.com with SMTP id x9so2991842ljc.5
 for <tarantool-patches@dev.tarantool.org>;
 Wed, 22 Jul 2020 08:41:57 -0700 (PDT)
Date: Wed, 22 Jul 2020 18:41:54 +0300
From: Cyrill Gorcunov <gorcunov@gmail.com>
Message-ID: <20200722154154.GA60766@grain>
References: <20200722153359.134718-1-gorcunov@gmail.com>
 <20200722153359.134718-5-gorcunov@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200722153359.134718-5-gorcunov@gmail.com>
Subject: Re: [Tarantool-patches] [PATCH 4/5] qsync: implement direct write
 of confirm/rollback into a journal
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: tml <tarantool-patches@dev.tarantool.org>
Cc: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>

On Wed, Jul 22, 2020 at 06:33:58PM +0300, Cyrill Gorcunov wrote:
> When we need to write CONFIRM or ROLLBACK message (which is just
> a binary record in msgpack format) into a journal we use txn code
> to allocate a new transaction, encode there a message and pass it
> to walk the long txn path before it hit the journal. This is not
> only resource wasting but also somehow strange from arhitectural
> point of view.
> 
> Instead lets encode a record on the stack and write it
> directly to the journal.
> 
> Closes #5129
> 
> Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>

It might be hard to review the diff, so the final result is
https://github.com/tarantool/tarantool/blob/gorcunov/gh-5129-journal/src/box/txn_limbo.c#L264