From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp46.i.mail.ru (smtp46.i.mail.ru [94.100.177.106]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 4BD74445320 for ; Wed, 22 Jul 2020 13:39:21 +0300 (MSK) Date: Wed, 22 Jul 2020 13:39:20 +0300 From: Kirill Yukhin Message-ID: <20200722103920.m5fv4bjfieviqitk@tarantool.org> References: <71f8d267d86ec77501c4aa2f25245a7fa952c8b3.1595412450.git.avtikhon@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <71f8d267d86ec77501c4aa2f25245a7fa952c8b3.1595412450.git.avtikhon@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH v1] gitlab-ci: setup local cleanup/checkout processes List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Alexander V. Tikhonov" Cc: tarantool-patches@dev.tarantool.org, Alexander Turenko Hello, On 22 июл 13:17, Alexander V. Tikhonov wrote: > Set cleanup based on docker for all of the jobs to avoid of fails > when the job before change could use docker and reassigned the > temporary files in the working directory. If the docker is not > available than no need to use it for cleanup and cleanup runs > using shell. Gitlab-ci clean flags disabled and reorganized localy > as shown at [1]. > > Disabled gitlab-ci checkout default process as shown at [2] to be > able to fix repository before the checkout. Found that previously > run gitlab-ci jobs could change permissions files at repository > which broke the checkouts at the next jobs. Used for checkout > strategy [3], for submodule update strategy [4]. Submodules local > update routine in .gitlab.mk file became unneeded and removed. > > List of steps made localy instead of gitlab-ci preparations: > > 1. Check/clone the Tarantool repository with submodules. > 2. For shell based jobs change ownership of all the sources > to 'gitlab-runner' user. (NOTE: in Docker based jobs the > 'gitlab-runner' user is not known.) > 3. Fetch Tarantool sources with branches and force checkout > of the testing commit. > 4. Update submodules recursively (use force where supports). > 5. Cleanup all the sources from all files except from repository. > > [1] https://docs.gitlab.com/ee/ci/yaml/README.html#git-clean-flags > [2] https://docs.gitlab.com/ee/ci/yaml/README.html#git-strategy > [3] https://docs.gitlab.com/ee/ci/yaml/README.html#git-checkout > [4] https://docs.gitlab.com/ee/ci/yaml/README.html#git-submodule-strategy > > Follows up #5036 LGTM. I've checked your patch into 1.10, 2.4, 2.5 and master. -- Regards, Kirill Yukhin