From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <korablev@tarantool.org>
Received: from smtp47.i.mail.ru (smtp47.i.mail.ru [94.100.177.107])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id BD372445320
 for <tarantool-patches@dev.tarantool.org>;
 Tue, 21 Jul 2020 21:19:50 +0300 (MSK)
Date: Tue, 21 Jul 2020 18:19:49 +0000
From: Nikita Pettik <korablev@tarantool.org>
Message-ID: <20200721181949.GB21662@tarantool.org>
References: <20200721110514.10344-1-i.kosarev@tarantool.org>
 <20200721180730.GK18920@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20200721180730.GK18920@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v2] lua: assert on lua_gettop()
	negative return value
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Igor Munkin <imun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

On 21 Jul 21:07, Igor Munkin wrote:
> > corresponding sane check with assert is introduced.
> > 
> > Closes #4649
> 
> Side note: I doubt this patch closes #4649. It just adds more
> diagnostics but the doesn't fix the root issue. I guess "Relates to" tag
> is much better here.

Agree.