From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gorcunov@gmail.com>
Received: from mail-lj1-f196.google.com (mail-lj1-f196.google.com
 [209.85.208.196])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 7621A445320
 for <tarantool-patches@dev.tarantool.org>;
 Tue, 21 Jul 2020 11:45:18 +0300 (MSK)
Received: by mail-lj1-f196.google.com with SMTP id f5so23172940ljj.10
 for <tarantool-patches@dev.tarantool.org>;
 Tue, 21 Jul 2020 01:45:18 -0700 (PDT)
Date: Tue, 21 Jul 2020 11:45:15 +0300
From: Cyrill Gorcunov <gorcunov@gmail.com>
Message-ID: <20200721084515.GF4221@grain>
References: <8c82ec8541391ee2558c51900af1525a8623ef6a.1593818521.git.v.shpilevoy@tarantool.org>
 <224d3b23-65b4-6533-6ac0-a040fc9b6af8@tarantool.org>
 <20200720222117.GC4221@grain>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200720222117.GC4221@grain>
Subject: Re: [Tarantool-patches] [PATCH 1/1] txn: remove TXN_IS_DONE check
 from txn_commit()
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>, tarantool-patches@dev.tarantool.org, sergos@tarantool.org

On Tue, Jul 21, 2020 at 01:21:17AM +0300, Cyrill Gorcunov wrote:
> On Mon, Jul 20, 2020 at 10:24:01PM +0200, Vladislav Shpilevoy wrote:
> > Still need somebody to take a look at this. It would
> > help to make txn_commit more straightforward.
> > 
> > Sergey Os.? Cyrill G. maybe?
> 
> The idea looks reasonable. Could you please rebase the patch
> on current master once time permit? This flag comes from the
> series where I've been reworking journal engine hunting the
> nil dereference in parallel applier code and after discussion
> with KostyaO we choose to make helper functions which would
> trigger error in case if async write is called from bootstrap
> and recover code.
> 
> Still removing code is always a good thing :-) I'll try to
> rebase it myself tomorrow if you wont beat me on it today.

I've updated the patch locally. Vlad, lets postpone this
particular patch -- I'm about to change journal code again
for qsync reason and will grab your patch on top. Then will
send it in the batch. Sounds ok?