From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-f194.google.com (mail-lj1-f194.google.com [209.85.208.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 8270D445320 for ; Tue, 21 Jul 2020 01:21:21 +0300 (MSK) Received: by mail-lj1-f194.google.com with SMTP id h22so21929228lji.9 for ; Mon, 20 Jul 2020 15:21:21 -0700 (PDT) Date: Tue, 21 Jul 2020 01:21:17 +0300 From: Cyrill Gorcunov Message-ID: <20200720222117.GC4221@grain> References: <8c82ec8541391ee2558c51900af1525a8623ef6a.1593818521.git.v.shpilevoy@tarantool.org> <224d3b23-65b4-6533-6ac0-a040fc9b6af8@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <224d3b23-65b4-6533-6ac0-a040fc9b6af8@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH 1/1] txn: remove TXN_IS_DONE check from txn_commit() List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladislav Shpilevoy Cc: tarantool-patches@dev.tarantool.org On Mon, Jul 20, 2020 at 10:24:01PM +0200, Vladislav Shpilevoy wrote: > Still need somebody to take a look at this. It would > help to make txn_commit more straightforward. > > Sergey Os.? Cyrill G. maybe? The idea looks reasonable. Could you please rebase the patch on current master once time permit? This flag comes from the series where I've been reworking journal engine hunting the nil dereference in parallel applier code and after discussion with KostyaO we choose to make helper functions which would trigger error in case if async write is called from bootstrap and recover code. Still removing code is always a good thing :-) I'll try to rebase it myself tomorrow if you wont beat me on it today.