From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-f196.google.com (mail-lj1-f196.google.com [209.85.208.196]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 7AAD0445320 for ; Tue, 21 Jul 2020 01:09:36 +0300 (MSK) Received: by mail-lj1-f196.google.com with SMTP id h22so21905660lji.9 for ; Mon, 20 Jul 2020 15:09:36 -0700 (PDT) Date: Tue, 21 Jul 2020 01:09:31 +0300 From: Cyrill Gorcunov Message-ID: <20200720220931.GB4221@grain> References: <917bd68fb91e1d113c65a2c74013371f379243a5.1595279482.git.v.shpilevoy@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <917bd68fb91e1d113c65a2c74013371f379243a5.1595279482.git.v.shpilevoy@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH 1/1] txn_limbo: use fiber_clock() instead of fiber_time() List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladislav Shpilevoy Cc: tarantool-patches@dev.tarantool.org On Mon, Jul 20, 2020 at 11:11:39PM +0200, Vladislav Shpilevoy wrote: > box.ctl.clear_synchro_queue() used fiber_time() > instead of fiber_clock() to wait for a timeout. This is wrong, > fiber_time() is realtime, not suitable for relative timeouts. > > For that purpose always should be used monotonic clock. The patch > fixes that. > > Follow up #4849 (side note: monotonic clocks do not account acpi-deep-sleep state, ie when cpu is in sleep state it wont be accounted, but i think it is impossible scenario for us. so put this note just for reference). Good catch! Acked-by: Cyrill Gorcunov