From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 4162D445320 for ; Mon, 20 Jul 2020 21:37:14 +0300 (MSK) Date: Mon, 20 Jul 2020 21:26:55 +0300 From: Igor Munkin Message-ID: <20200720182655.GH18920@tarantool.org> References: <5bc03933be6334d9b4c1f0919817eb282c029e97.1594908932.git.sergeyb@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <5bc03933be6334d9b4c1f0919817eb282c029e97.1594908932.git.sergeyb@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH] test: fix warnings spotted by luacheck List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: sergeyb@tarantool.org Cc: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org, alexander.turenko@tarantool.org Sergey, Thanks for the patch! I've already given my LGTM for this one here[1]. I guess the fixes are quite similar and obvious, so the patch can be applied out of order to our LuaJIT repo. However, Vlad still doesn't approved these changes, so let's wait his reply. On 16.07.20, sergeyb@tarantool.org wrote: > From: Sergey Bronnikov > > luacheck is integrated in tarantool CI pipeline and respects .luacheckrc in > tarantool repo, so jit global is suppressed there. > > Co-authored-by: Igor Munkin > Reviewed-by: Igor Munkin > --- > ...gh-4476-fix-string-find-recording.test.lua | 6 ++--- > .../lj-494-table-chain-infinite-loop.test.lua | 26 +++++++++---------- > test/or-232-unsink-64-kptr.test.lua | 1 + > 3 files changed, 17 insertions(+), 16 deletions(-) > > -- > 2.26.2 > [1]: https://lists.tarantool.org/pipermail/tarantool-patches/2020-April/016301.html -- Best regards, IM