From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id A212A445320 for ; Mon, 20 Jul 2020 14:44:33 +0300 (MSK) Date: Mon, 20 Jul 2020 14:34:14 +0300 From: Igor Munkin Message-ID: <20200720113414.GG18920@tarantool.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Subject: Re: [Tarantool-patches] [PATCH] lua: do not use internal api in public headers List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Timur Safin Cc: tarantool-patches@dev.tarantool.org Timur, Thanks for your changes! It does solve your problem, but I propose to drop this patch in favour of mine[1]. On 20.07.20, Timur Safin wrote: > src/lua/utils.[ch] is part of public api which will > be integrated into module.h at the build step. It > should not refer to the internal LuaJIT API like > lj_state_growstack1(), otherwise it has not chance > to be linked in while building external binary module. > > Relates to vshard-cluster-api#5 Side note: I doubt this line refers the issue the right way. > --- > > Branch: https://github.com/tarantool/tarantool/tree/tsafin/gh-vshard-cluster-api-5-no-private-api > Issue: https://github.com/tarantool/vshard-cluster-api/issues/5 > > src/lua/utils.c | 13 +++++++++++++ > src/lua/utils.h | 14 ++------------ > 2 files changed, 15 insertions(+), 12 deletions(-) > [1]: https://lists.tarantool.org/pipermail/tarantool-patches/2020-July/018745.html -- Best regards, IM