From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-f195.google.com (mail-lj1-f195.google.com [209.85.208.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 669D2445320 for ; Fri, 17 Jul 2020 23:43:54 +0300 (MSK) Received: by mail-lj1-f195.google.com with SMTP id s9so14098751ljm.11 for ; Fri, 17 Jul 2020 13:43:54 -0700 (PDT) Date: Fri, 17 Jul 2020 23:43:51 +0300 From: Cyrill Gorcunov Message-ID: <20200717204351.GC2613@grain> References: <20200714144440.551127-1-gorcunov@gmail.com> <20200714144440.551127-5-gorcunov@gmail.com> <20200714145358.GG296695@grain> <20200717072550.GA2613@grain> <20200717203336.GB2613@grain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200717203336.GB2613@grain> Subject: Re: [Tarantool-patches] [PATCH v2 4/4] qsync: don't send negative timeouts into fiber_cond_wait_timeout List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladislav Shpilevoy , tml On Fri, Jul 17, 2020 at 11:33:36PM +0300, Cyrill Gorcunov wrote: > On Fri, Jul 17, 2020 at 10:03:49PM +0200, Vladislav Shpilevoy wrote: > > > > > > Am I missing something obvious here? > > > > I still don't see how to trigger this assert. Please, show a code sample with > > error injection, if you think that will help. I explicitly added line > > 'timeout = -1;' and all worked fine. > > > --- > [cyrill@grain test] ./test-run.py replication/qsync_basic.test.lua > ... > You did the same thing? Note that it requires debug build. Actually it is different issue. I think you can safely drop this patch.