From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp16.mail.ru (smtp16.mail.ru [94.100.176.153]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id D730B445320 for ; Fri, 17 Jul 2020 20:25:31 +0300 (MSK) From: Ilya Kosarev Date: Fri, 17 Jul 2020 20:25:29 +0300 Message-Id: <20200717172529.12608-1-i.kosarev@tarantool.org> Subject: [Tarantool-patches] [PATCH] lua: assert on lua_gettop() negative return value List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: imun@tarantool.org Cc: tarantool-patches@dev.tarantool.org In case lua_gettop() called from encode_lua_call() returns negative value, we will segfault in iproto_reply_error() with empty diag, as far as it is unexpected error path not covered with diagnostics. Thus corresponding sane check with assert is introduced. Closes #4649 --- Branch: https://github.com/tarantool/tarantool/tree/i.kosarev/gh-4649-sane-check-on-lua_gettop Issue: https://github.com/tarantool/tarantool/issues/4649 @ChangeLog: * Raise assert on lua_gettop() negative return value (gh-4649). src/box/lua/call.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/box/lua/call.c b/src/box/lua/call.c index ca871e077..75634de5b 100644 --- a/src/box/lua/call.c +++ b/src/box/lua/call.c @@ -361,6 +361,7 @@ encode_lua_call(lua_State *L) struct luaL_serializer *cfg = luaL_msgpack_default; int size = lua_gettop(port->L); + assert(size >= 0); for (int i = 1; i <= size; ++i) luamp_encode(port->L, cfg, &stream, i); port->size = size; -- 2.17.1