From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <alexander.turenko@tarantool.org>
Received: from smtp53.i.mail.ru (smtp53.i.mail.ru [94.100.177.113])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id A42D2445320
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 17 Jul 2020 14:28:57 +0300 (MSK)
Date: Fri, 17 Jul 2020 14:28:10 +0300
From: Alexander Turenko <alexander.turenko@tarantool.org>
Message-ID: <20200717112810.zfosu32k76xaw7ty@tkn_work_nb>
References: <cover.1592416673.git.alexander.turenko@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <cover.1592416673.git.alexander.turenko@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v2 0/3] Merger's NULL defererence
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>, Igor Munkin <imun@tarantool.org>
Cc: Yukhin Kirill <k.yukhin@corp.mail.ru>, tarantool-patches@dev.tarantool.org

> Changelog entry
> ---------------
> 
> @ChangeLog
> 
> - merger: fix NULL pointer dereference when merger is called via the
>   binary protocol (say, via net.box) (gh-4954)
> 
> Links
> -----
> 
> https://github.com/tarantool/tarantool/issues/4954
> Totktonada/gh-4954-fix-merger-segfault-full-ci

Made all suggested review fixes (or discussed where I disagree). Thank
you, Vlad and Igor!

Pushed to master.

Pushed to 2.4. Removed box-tap/gh-4954-merger-via-c.test.lua from the
2nd commit, because it depends on exposing all symbols from the
executable (#2971).

Pushed to 2.3. Applied the same changes as for 2.4.

Updated all relevant release notes with the changelog entry.

Removed the Totktonada/gh-4954-fix-merger-segfault-full-ci branch.

WBR, Alexander Turenko.