From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sergeyb@tarantool.org>
Received: from smtp51.i.mail.ru (smtp51.i.mail.ru [94.100.177.111])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 998DD445320
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 17 Jul 2020 11:09:10 +0300 (MSK)
Date: Fri, 17 Jul 2020 11:09:08 +0300
From: Sergey Bronnikov <sergeyb@tarantool.org>
Message-ID: <20200717080908.GA89451@pony.bronevichok.ru>
References: <cover.1594907318.git.sergeyb@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <cover.1594907318.git.sergeyb@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH 00/19] Add static analysis of Lua
 code in test/ with luacheck
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org, imun@tarantool.org
Cc: alexander.turenko@tarantool.org

On 17:11 Thu 16 Jul , sergeyb@tarantool.org wrote:
> From: Sergey Bronnikov <sergeyb@tarantool.org>

<snipped>

> Changelog v2:
>
> - reverted changes for diff-based tests
> - reverted changes for suppressed warnings

I used this command-line to make sure all changes for globally
suppressed warnings reverted:

.rocks/bin/luacheck --only W431,W432,W421,W412,W411,212/self,143/table,143/string,143/debug --codes  test/

> - format .luacheckrc according to Lua style guide
> - created GH issue for every ignored warning in a separated files
> - make each commit atomic again - all changes in commits are related to
> commit itself, not other commits

<snipped>