From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id B0E3A445320 for ; Fri, 17 Jul 2020 00:15:01 +0300 (MSK) Date: Fri, 17 Jul 2020 00:04:43 +0300 From: Igor Munkin Message-ID: <20200716210443.GQ5559@tarantool.org> References: <20200629121118.21596-1-arkholga@tarantool.org> <20200629121118.21596-2-arkholga@tarantool.org> <20200701213447.GE5559@tarantool.org> <16d471e3-d578-7b12-6a4f-08814a2f1b64@tarantool.org> <20200709010804.7kejojfasvu7o7oj@tkn_work_nb> <20200715144023.pll42732ijjw6obo@tkn_work_nb> <20200716175618.GN5559@tarantool.org> <1d010980-646d-3c73-bef7-1009fff6609c@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1d010980-646d-3c73-bef7-1009fff6609c@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH 1/1] box: fixed box.info:memory() List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Olga Arkhangelskaia Cc: tarantool-patches@dev.tarantool.org, Alexander Turenko Olya, Thanks for the fixes! I checked the upstream. The patch LGTM except the tiny nit. Sasha, please proceed with the patch. On 16.07.20, Olga Arkhangelskaia wrote: > When box.info:memory is called, it has box.info table as a first Typo: s/a first/the first/. > argument (seehttps://www.lua.org/manual/5.1/manual.html#2.8). While > printing the table, lbox_info_memory_call adds box.info.memory's fields > to the box.info table. To avoid this effect and return just > box.info.memory we put an empty table on the Lua stack at the beginning > of the lbox_info_memory_call function. Instead adding fields to box.info > table lbox_info_memory_call fills that empty table. -- Best regards, IM