From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <avtikhon@tarantool.org>
Received: from smtp36.i.mail.ru (smtp36.i.mail.ru [94.100.177.96])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id AFB40445320
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 16 Jul 2020 22:15:43 +0300 (MSK)
Date: Thu, 16 Jul 2020 22:15:41 +0300
From: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
Message-ID: <20200716191541.GA21687@hpalx>
References: <b5fb66465c420ec3a0f642692d769ada6c76b573.1594912145.git.avtikhon@tarantool.org>
 <20200716180206.tamvh5y2qbbuxqnj@tkn_work_nb>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200716180206.tamvh5y2qbbuxqnj@tkn_work_nb>
Subject: Re: [Tarantool-patches] [PATCH v1] Bump curl repository to 7.71.1
	version
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Alexander Turenko <alexander.turenko@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Hi Alexander, thanks for the clear instructions, I've made all the
corrections as you suggested.

On Thu, Jul 16, 2020 at 09:02:06PM +0300, Alexander Turenko wrote:
> > Bump curl repository to 7.71.1 version
> 
> Nit: I would say that we update a submodule here (not a repository),
> because 'bump repository' looks as `git push` action for me.
> 
> Please, add a prefix (I suggest 'build').
> 
> See [1] for example.
>

Rewrote in the style as you showed.

> >
> > Check the new version.
> 
> To solve a problem, right? Please, clarify it or at least mention it.
> AFAIR, I described the security problem that is related for us in the
> issue (there are two security problems, but only one looks related to
> us).
>

Sure, done.

> > 
> > Closes #4698
> > ---
> > 
> > Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-4698-curl-7-71-1
> > Issue: https://github.com/tarantool/tarantool/issues/4698
> > 
> >  third_party/curl | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/third_party/curl b/third_party/curl
> > index 9cd755e1d..12af024bc 160000
> > --- a/third_party/curl
> > +++ b/third_party/curl
> > @@ -1 +1 @@
> > -Subproject commit 9cd755e1d768bbf228e7c9faf223b7459f7e0105
> > +Subproject commit 12af024bc85606b14ffc415413a7e86e6bbee7eb
> 
> Please, checkout the curl-7_71_1 tag, not the HEAD of
> curl-7_71_1-tarantool branch, which is for building using CMake. See [2]
> starting from words "Please, don't mix".
> 
> [1]: https://github.com/tarantool/tarantool/commit/4c2d1eff29848cc2ed47cd1d3ca23152fed2e3b9
> [2]: https://lists.tarantool.org/pipermail/tarantool-patches/2020-July/018443.html

Right, I've just forgot that OOS build is not in the trunk now.