From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <korablev@tarantool.org>
Received: from smtp34.i.mail.ru (smtp34.i.mail.ru [94.100.177.94])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 8ACB4445320
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 16 Jul 2020 20:09:28 +0300 (MSK)
Date: Thu, 16 Jul 2020 17:09:27 +0000
From: Nikita Pettik <korablev@tarantool.org>
Message-ID: <20200716170927.GF433@tarantool.org>
References: <cover.1594909974.git.imeevma@gmail.com>
 <ea5e9f05e6d24c8f98bf0e603fe044610b559e58.1594909974.git.imeevma@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <ea5e9f05e6d24c8f98bf0e603fe044610b559e58.1594909974.git.imeevma@gmail.com>
Subject: Re: [Tarantool-patches] [PATCH v6 08/22] sql: check args of lower()
	and upper()
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: imeevma@tarantool.org
Cc: tarantool-patches@dev.tarantool.org

On 16 Jul 17:46, imeevma@tarantool.org wrote:
> After this patch, the argument types of the lower() and upper()
> functions will be checked properly.
> 
> Part of #4159
> ---
>  src/box/sql/func.c          |  15 +++---
>  test/sql-tap/cse.test.lua   |   8 +--
>  test/sql-tap/func.test.lua  |   8 +--
>  test/sql-tap/func5.test.lua | 100 +++++++++++++++++++++++++++++++++++-
>  test/sql/boolean.result     |  20 ++------
>  test/sql/types.result       |  38 ++++----------
>  6 files changed, 127 insertions(+), 62 deletions(-)
>

LGTM