From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp54.i.mail.ru (smtp54.i.mail.ru [217.69.128.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id EB2C2445320 for ; Thu, 16 Jul 2020 19:31:23 +0300 (MSK) Date: Thu, 16 Jul 2020 16:31:22 +0000 From: Nikita Pettik Message-ID: <20200716163122.GD433@tarantool.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Subject: Re: [Tarantool-patches] [PATCH v6 06/22] sql: check args of length() List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: imeevma@tarantool.org Cc: tarantool-patches@dev.tarantool.org On 16 Jul 17:45, imeevma@tarantool.org wrote: > After this patch, the argument types of the length(), char_length() and > character_length() functions will be checked properly. > > Part of #4159 > --- > src/box/sql/func.c | 48 ++++------- > test/sql-tap/func.test.lua | 2 +- > test/sql-tap/func5.test.lua | 149 ++++++++++++++++++++++++++++++++- > test/sql-tap/orderby1.test.lua | 2 +- > test/sql/boolean.result | 10 +-- > 5 files changed, 170 insertions(+), 41 deletions(-) LGTM