From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <korablev@tarantool.org>
Received: from smtp54.i.mail.ru (smtp54.i.mail.ru [217.69.128.34])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id EB2C2445320
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 16 Jul 2020 19:31:23 +0300 (MSK)
Date: Thu, 16 Jul 2020 16:31:22 +0000
From: Nikita Pettik <korablev@tarantool.org>
Message-ID: <20200716163122.GD433@tarantool.org>
References: <cover.1594909974.git.imeevma@gmail.com>
 <e8f345be824a3b1f35ad862067b683e0fc695f9b.1594909974.git.imeevma@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <e8f345be824a3b1f35ad862067b683e0fc695f9b.1594909974.git.imeevma@gmail.com>
Subject: Re: [Tarantool-patches] [PATCH v6 06/22] sql: check args of length()
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: imeevma@tarantool.org
Cc: tarantool-patches@dev.tarantool.org

On 16 Jul 17:45, imeevma@tarantool.org wrote:
> After this patch, the argument types of the length(), char_length() and
> character_length() functions will be checked properly.
> 
> Part of #4159
> ---
>  src/box/sql/func.c             |  48 ++++-------
>  test/sql-tap/func.test.lua     |   2 +-
>  test/sql-tap/func5.test.lua    | 149 ++++++++++++++++++++++++++++++++-
>  test/sql-tap/orderby1.test.lua |   2 +-
>  test/sql/boolean.result        |  10 +--
>  5 files changed, 170 insertions(+), 41 deletions(-)


LGTM