From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp57.i.mail.ru (smtp57.i.mail.ru [217.69.128.37]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id A4DA1445320 for ; Wed, 15 Jul 2020 19:51:58 +0300 (MSK) Date: Wed, 15 Jul 2020 16:51:57 +0000 From: Nikita Pettik Message-ID: <20200715165157.GI26087@tarantool.org> References: <1594821336-14468-1-git-send-email-alyapunov@tarantool.org> <1594821336-14468-9-git-send-email-alyapunov@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1594821336-14468-9-git-send-email-alyapunov@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH v3 08/13] txm: introduce tx manager List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Aleksandr Lyapunov Cc: tarantool-patches@dev.tarantool.org On 15 Jul 16:55, Aleksandr Lyapunov wrote: > Define TX manager. It will store data for MVCC and conflict manager. > Define also 'use_mvcc_engine' in config that enables MVCC engine. > > Part of #4897 > --- > src/box/lua/load_cfg.lua | 2 ++ > src/box/txn.c | 21 +++++++++++++++++++++ > src/box/txn.h | 12 ++++++++++++ > src/main.cc | 5 +++++ > test/app-tap/init_script.result | 1 + > test/box/admin.result | 2 ++ > test/box/cfg.result | 4 ++++ > 7 files changed, 47 insertions(+) > > diff --git a/src/box/lua/load_cfg.lua b/src/box/lua/load_cfg.lua > index 107bc15..8b40b29 100644 > --- a/src/box/lua/load_cfg.lua > +++ b/src/box/lua/load_cfg.lua > @@ -82,6 +82,7 @@ local default_cfg = { > coredump = false, > read_only = false, > hot_standby = false, > + use_mvcc_engine = false, Mb memtx_mvcc or memtx_mvcc_engine? I mean to tell it from vinyl. The rest is obvious, LGTM