From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <korablev@tarantool.org>
Received: from smtp33.i.mail.ru (smtp33.i.mail.ru [94.100.177.93])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 9E7C9445320
 for <tarantool-patches@dev.tarantool.org>;
 Wed, 15 Jul 2020 19:04:58 +0300 (MSK)
Date: Wed, 15 Jul 2020 16:04:57 +0000
From: Nikita Pettik <korablev@tarantool.org>
Message-ID: <20200715160457.GD26087@tarantool.org>
References: <1594821336-14468-1-git-send-email-alyapunov@tarantool.org>
 <1594821336-14468-4-git-send-email-alyapunov@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <1594821336-14468-4-git-send-email-alyapunov@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v3 03/13] vinyl: rename tx_manager
 -> vy_tx_manager
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Aleksandr Lyapunov <alyapunov@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

On 15 Jul 16:55, Aleksandr Lyapunov wrote:
> Apart from other vinyl objects that are named with "vy_" prefix,
> its transaction manager (tx_manager) have no such prefix.
> It should have in order to avoid conflicts with global tx manager.
> 
> Needed for #4897
> ---

LGTM. The only concern I have now - mb we'd better call
new TX manager in memtx not tx_manager, but mem_tx_manager or
memtx_tx_manager? I mean tx_ prefix is more general than memtx_..