From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 39290445321 for ; Tue, 14 Jul 2020 19:01:59 +0300 (MSK) Date: Tue, 14 Jul 2020 19:01:57 +0300 From: Mergen Imeev Message-ID: <20200714160157.GA250285@tarantool.org> References: <20200708114718.38910-1-roman.habibov@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200708114718.38910-1-roman.habibov@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH 0/2] Follow-up for "_session_settings" space List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Roman Khabibov Cc: tarantool-patches@dev.tarantool.org Hi! Thank you for the patches. See 2 comments below. On Wed, Jul 08, 2020 at 02:47:16PM +0300, Roman Khabibov wrote: 1. Please write some description of the patch-set. > @ChangeLog > - Fix _session_settings name in error messages > - Raname "sql_defer_foreign_keys" setting to > "sql_defer_foreign_key_changes". 2. Please refer to the 'Code review procedure' on the Wiki for the rules for writing ChangeLog correctly. It should be written on one line and with the issue number. > > Branch: https://github.com/tarantool/tarantool/tree/romanhabibov/gh-4732-ss-space > Issue: https://github.com/tarantool/tarantool/issues/4732 > > Roman Khabibov (2): > sql: fix _session_settings name in error messages > sql: clarify "sql_defer_foreign_keys" setting name > > src/box/session_settings.c | 10 +- > test/box/session_settings.result | 108 +++++++++++----------- > test/box/session_settings.test.lua | 86 ++++++++--------- > test/sql/transitive-transactions.result | 4 +- > test/sql/transitive-transactions.test.lua | 4 +- > 5 files changed, 106 insertions(+), 106 deletions(-) > > -- > 2.21.0 (Apple Git-122) >