From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kyukhin@tarantool.org>
Received: from smtp32.i.mail.ru (smtp32.i.mail.ru [94.100.177.92])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 73304445320
 for <tarantool-patches@dev.tarantool.org>;
 Tue, 14 Jul 2020 14:24:24 +0300 (MSK)
Date: Tue, 14 Jul 2020 14:24:23 +0300
From: Kirill Yukhin <kyukhin@tarantool.org>
Message-ID: <20200714112423.ggbam4uo6asw2dz2@tarantool.org>
References: <c0344914698895a9ef4172ee4e9a75ce563a2693.1594723276.git.avtikhon@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <c0344914698895a9ef4172ee4e9a75ce563a2693.1594723276.git.avtikhon@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v1] test: replication/wal_rw_stress
	fix wait_cond
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org, Alexander Turenko <alexander.turenko@tarantool.org>

Hello,

On 14 июл 13:42, Alexander V. Tikhonov wrote:
> Found that on heavy loaded hosts the test tries to check replication
> downstream status when downstream structure is not ready and it fails
> with the error:
> 
> [017] --- replication/wal_rw_stress.result	Thu Jul  9 17:04:16 2020
> [017] +++ replication/wal_rw_stress.reject	Fri May  8 08:25:15 2020
> [017] @@ -75,7 +75,8 @@
> [017]      return box.info.replication[1].downstream.status ~= 'stopped' \
> [017]  end) or box.info
> [017]  ---
> [017] -- true
> [017] +- error: '[string "return test_run:wait_cond(function()         ..."]:1: attempt to
> [017] +    index field ''downstream'' (a nil value)'
> [017]  ...
> [017]  test_run:cmd("switch default")
> [017]  ---
> [017]
> 
> So the wait condition should start from the check of the downstream
> structure availability.
> 
> Follows up #4977
> ---
> 
> Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-4977-test-replication-wal_rw_stress
> Issue: https://github.com/tarantool/tarantool/issues/4977

LGTM.

I've checked your patch into 1.10, 2.3, 2.4 and master.

--
Regards, Kirill Yukhin