From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp32.i.mail.ru (smtp32.i.mail.ru [94.100.177.92]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 60A3C445320 for ; Mon, 13 Jul 2020 16:40:35 +0300 (MSK) Date: Mon, 13 Jul 2020 16:40:34 +0300 From: Kirill Yukhin Message-ID: <20200713134034.rbuijgg7g3txklif@tarantool.org> References: <1594210027-332-1-git-send-email-alyapunov@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1594210027-332-1-git-send-email-alyapunov@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH] Fix make_scoped_guard usage List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Aleksandr Lyapunov Cc: tarantool-patches@dev.tarantool.org Hello, On 08 июл 15:07, Aleksandr Lyapunov wrote: > make_scoped_guard usually captures scope by [=]. > In some cases it could lead to unexpected results. > I found several problems and fixed them. > > GH issue: https://github.com/tarantool/tarantool/issues/5154 > GH branch: https://github.com/tarantool/tarantool/tree/alyapunov/gh-5154-wrong-scoped-guards > > Aleksandr Lyapunov (1): > Fix wrong make_scoped_guard usage I've checked your patch into 2.3, 2.4 and master. -- Regards, Kirill Yukhin