From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp18.mail.ru (smtp18.mail.ru [94.100.176.155]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 7081A445320 for ; Mon, 13 Jul 2020 16:38:10 +0300 (MSK) Date: Mon, 13 Jul 2020 16:38:09 +0300 From: Kirill Yukhin Message-ID: <20200713133809.kr72iv2huk65hf62@tarantool.org> References: <20200712134316.31126-1-i.kosarev@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200712134316.31126-1-i.kosarev@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH v2] tuple: make fields nullable by default except array/map List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ilya Kosarev Cc: tarantool-patches@dev.tarantool.org Hello, On 12 июл 16:43, Ilya Kosarev wrote: > Since e1d3fe8ab8eed65394ad17409401a93b6fcdc435 (tuple format: don't > allow null where array/map is expected) tuple fields are non-nullable > by default. It seems strange at least in case we have implicit fields > in front of explicit nullable field. Also it causes incorrect behaviour > in case of using explicitly nullable array/map fields for multikey > index. > Now fields are nullable by default except arrays & maps, as far > as their implicit nullability might break field accessors expectations, > provide confusing error messages and cause incorrect behaviour of > tuple_multikey_count(). In case explicitly nullable array/map fields > are being used for multikey index, clear error message is provided. > > Closes #5027 > --- > Branch: https://github.com/tarantool/tarantool/tree/i.kosarev/gh-5027-fix-tuple-fields-nullability > Issue: https://github.com/tarantool/tarantool/issues/5027 LGTM. I've checked your patch into 2.3, 2.4 and master. -- Regards, Kirill Yukhin