From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp14.mail.ru (smtp14.mail.ru [94.100.181.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 3C25C445320 for ; Mon, 13 Jul 2020 12:41:42 +0300 (MSK) Date: Mon, 13 Jul 2020 12:41:41 +0300 From: Kirill Yukhin Message-ID: <20200713094141.c5f7hbnbweuax66i@tarantool.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Subject: Re: [Tarantool-patches] [PATCH 1/1] recovery: handle local sync txns during recovery List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladislav Shpilevoy Cc: tarantool-patches@dev.tarantool.org Hello, On 11 июл 19:05, Vladislav Shpilevoy wrote: > Recovery uses txn_commit_async() so as not to block the recovery > process when a synchronous transaction is met. They are either > committed later when CONFIRM is read, or stay in the limbo after > recovery. > > However txn_commit_async() assumed it is used for remote > transactions only, and had some assertions about that. One of them > crashed in case master restarted and had any synchronous > transaction in WAL. > > The patch makes txn_commit_async() not assume anything about > transaction's origin. > > Closes #5163 > --- > Branch: http://github.com/tarantool/tarantool/tree/gerold103/gh-5163-qsync-restart-crash > Issue: https://github.com/tarantool/tarantool/issues/5163 LGTM. I've checked your patch into master. -- Regards, Kirill Yukhin